Jack Horton

Results 11 issues of Jack Horton

We have recently been notified by our friends at Google that the following code crashes Chakra: ```js const options = {}; Object.defineProperty(options, "year", { get() { Object.defineProperty(options, "year", { get()...

c: spec
s: comment

We require --with-intl={small-icu|full-icu|system-icu} when building on Linux and macOS, but when you explicitly say to not use intl/ICU, `gyp` crashes due to an undefined reference [here](https://github.com/nodejs/node-chakracore/blob/master/deps/chakrashim/chakracore.gyp#L23). We should probably exit...

bug
compatibility
build

chakra_shim.js contains implementations of lots of functions that we should probably consider moving back into native, such as hot type checks. The interface to access it is also pretty messy...

* **Version**: v10.0.0-pre * **Platform**: Windows/x86 * **Subsystem**: fs Test sequential/test-fs-readfile-tostring-fail is flaky for x86 windows builds: https://mseng.visualstudio.com/Node.js%20Core%20Runtime/_build/index?buildId=5108430&_a=summary

test

f76ef504326f8a37cdb0d3dae705239d685abffc brought in a significant change to assert.js that uses V8 internal APIs to read the stack to find the assert callsite in order to use the program source code...

V8 internals
modified test

Blocked on https://github.com/Microsoft/ChakraCore/issues/4635

disabled test

https://github.com/nodejs/node/pull/15702 brought in changes that made parallel/test-http2-server-rst-stream unstable. b51dc3856e marked it as flaky for the time being, as it requires further investigation.

compatibility
test

* napi_jsrt stub: https://github.com/nodejs/node-chakracore/blob/070fe0f475e0dcde54867cd8eb6d2fc960c9e5b1/src/node_api_jsrt.cc#L2520 * node pull request: https://github.com/nodejs/node/pull/14310 @chris--young If you are already looking into this, let us know anything you find!

question

I was developing an application that caches protobuf messages serialized as byte arrays when I began looking into the various ways of deserializing those messages and noticed a discrepancy between...

**Bicep version** 0.4.1124 **Describe the bug** If you have two templates `parent.bicep` and `child.bicep` where `child.bicep` is included as a module from `parent.bicep`, rebuilding templates with `dotnet build` will only...

bug
investigate