node-chakracore icon indicating copy to clipboard operation
node-chakracore copied to clipboard

./configure crashes when run with --without-intl

Open jackhorton opened this issue 8 years ago • 2 comments

We require --with-intl={small-icu|full-icu|system-icu} when building on Linux and macOS, but when you explicitly say to not use intl/ICU, gyp crashes due to an undefined reference here. We should probably exit gracefully with a nice message in the future.

jackhorton avatar Sep 19 '17 21:09 jackhorton

It's not just an undefined reference issue. See the first and last line of https://github.com/nodejs/node-chakracore/blob/master/deps/chakrashim/chakracore.gyp#L82-L97 . No matter what configure arguments are, we build with intl.

obastemur avatar Nov 07 '17 12:11 obastemur

I thought it was that no matter the arguments to configure, we build with icu. Node conflates ICU and Intl to mean the same thing, but we use ICU for Intl as well as other things. So, --without-intl sounds, to me, like we should disable Intl and use the system ICU for our other ICU things.

jackhorton avatar Nov 07 '17 16:11 jackhorton