Jack Francis
Jack Francis
@enxebre @alexeldeib is this PR getting close to addressing #4526? Obviously simply changing the capi equality implementation will require per-cloud-provider changes in their cluster-api providers in order to prevent breakage....
@sedefsavas can you PTAL at this change and confirm what @alexeldeib is suggesting thank you! @CecileRobertMichon are you able to speak authoritiatively on capd ramifications?
@enxebre I'm not sure how `IndexKey()` is affected by this change
> > @enxebre I'm not sure how IndexKey() is affected by this change > > `// This is useful to use the providerID as a reliable index between nodes and...
@enxebre got it, updated
/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-full-main
Correction to my comment above, the `IndexKey()` has now been made equivalent to `String()` (not `CloudProvider()`). That change has been realized in the PR now, tests look good. I think...
@vincepri @alexeldeib can we re-clarify what the "fallback behavior" is exactly? Reading through the above thread, it seems pretty clear that the current state of the changeset in this PR...
Hi @mtougeron, I think the first thing we want to do is validate that AKS itself supports the create flow you outlined (install into a custom (pre-existing) VNET + custom...