Jack Francis
Jack Francis
Overall lgtm, added some minor comments to address before final merging. Thanks!
/cherry-pick release-1.4
@CecileRobertMichon don't our VMSS tests already have this? https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/a7a55bf327393858ead8fcc0632f9998cb18cdee/test/e2e/azure_test.go#L386
/remove-lifecycle stale A quick thought: the easiest test delivery/validation mechanism would be a helm chart that wraps a `Job` resource which runs and if finished to completion indicates a successful...
I've added some comments for consideration. Overall this lgtm, thanks for doing the hard work of documenting all of our learnings from implementing Managed Kubernetes, so that future providers will...
/reopen /remove-lifecycle rotten
An implementation question: is the version of Azure CNI currently configurable? cc @craiglpeters
A reminder to use the "transparent" mode configuration when implementing a capz + Azure CNI scenario. This AKS Engine PR configures Azure CNI for "transparent" mode by default: https://github.com/Azure/aks-engine/pull/3958 The...
/remove-lifecycle stale