Jack Francis comments

Results 586 comments of


                                            Jack Francis

Support multiple CIDR blocks and multiple subnets in AzureManagedControlPlane

/reopen /remove-lifecycle rotten

WIP AKS: enable IsVnetManaged with rate limiting and 429 retry

> Not sure if this is relevant, but should the commit message also be changed to be more relevant to what the PR is actually doing now? I'm not sure...

WIP AKS: enable IsVnetManaged with rate limiting and 429 retry

/retitle AKS: enable isVnetManaged, add caching

WIP AKS: enable IsVnetManaged with rate limiting and 429 retry

> > Additionally, in order to account for additional calls against the Azure APIs I've wired in a rate limiting + HTTP 429 retry solution (inspired by cloud-provider-azure). > >...

WIP AKS: enable IsVnetManaged with rate limiting and 429 retry

/retest

WIP AKS: enable IsVnetManaged with rate limiting and 429 retry

@mtougeron @CecileRobertMichon this is ready for another (hopefully final? 🤞) review round

Cluster Name regex validation prevents valid Kubernetes object names

/remove-lifecycle rotten

Document the new release cadence and support policy

I agree. 1. We should probably as a rule "require" test changes/fixes/evolutions to be cherry-picked into the last release branch, so that we minimize friction for any critical test fix...

Document the new release cadence and support policy

/assign

Update e2e tests to verify all system pods are ready before executing tests

@jsturtevant I'm not sure I understand the need for this, but I think I have an idea how we might do this. Do we still want to make this change...