Jack Francis

Results 586 comments of Jack Francis

I agree with folks who suggest we should update the helm chart to reference 1.33.0. I'll do that today!

/cherry-pick cluster-autoscaler-release-1.30 /cherry-pick cluster-autoscaler-release-1.31 /cherry-pick cluster-autoscaler-release-1.32 /cherry-pick cluster-autoscaler-release-1.33

/cherry-pick cluster-autoscaler-release-1.31

/cherry-pick cluster-autoscaler-release-1.32

/cherry-pick cluster-autoscaler-release-1.33

I added some additional nits, but overall I'm happy with the direction of the API that represents a consensus between @ellistarn @liggitt @towca (and others). lgtm after incorporation of that...

@willie-yao is there a reason we're merging this directly into the 1.29 release branch as opposed to landing in main and then backporting to the desired release branches?

@willie-yao makes sense Are we able to classify this change in a semver-agreeable manner that would be appropriate for a future patch release? (i.e., bug)