Jack Francis

Results 586 comments of Jack Francis

See this comment here: https://github.com/kubernetes/autoscaler/issues/6631#issuecomment-2380159234 The main thing we want to do here is to add clusterIP to the values.yaml file, and to run `helm-docs` command line tool to regenerate...

/lgtm cancel /remove-kind/bug

@eshiettjoseph @Shubham82 this PR is next in the queue for merging, so if you rebase on top of master and rev the chart version again it should be the last...

@Shubham82 I'll happily lgtm an equivalent version of this change in a new PR!

@killianmuldoon it seems that flaky dualstack tests are general and not related to MachinePools? Ref: - https://github.com/kubernetes-sigs/cluster-api/pull/9477 @willie-yao is tracking restoring those tests as part of graduating MachinePool from experimental....

Yikes, fun one :) @willie-yao you should be able to re-introduce MachinePools into tests and we'll be able to confirm right away that there's no MachinePool regression here.

Ref: https://learn.microsoft.com/en-us/azure/aks/use-system-pools?tabs=azure-cli