autoscaler
autoscaler copied to clipboard
kubernetes
Omit fake pods during eviction
What type of PR is this?
/kind bug
What this PR does / why we need it:
When using fake (virtual) pods, Cluster Autoscaler tries to evict them during a scale-down, triggering NotFound error. Fake pods should be omitted during eviction.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: krzysied, x13n
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~cluster-autoscaler/OWNERS~~ [x13n]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/cherry-pick cluster-autoscaler-release-1.30 /cherry-pick cluster-autoscaler-release-1.31 /cherry-pick cluster-autoscaler-release-1.32 /cherry-pick cluster-autoscaler-release-1.33
@jackfrancis: #8273 failed to apply on top of branch "cluster-autoscaler-release-1.30":
Applying: Export fake pods definition to a dedicated module
Using index info to reconstruct a base tree...
A cluster-autoscaler/processors/podinjection/enforce_injected_pods_limit_processor.go
A cluster-autoscaler/processors/podinjection/enforce_injected_pods_limit_processor_test.go
A cluster-autoscaler/processors/podinjection/pod_injection_processor.go
A cluster-autoscaler/processors/podinjection/pod_injection_processor_test.go
A cluster-autoscaler/processors/podinjection/scale_up_status_processor.go
A cluster-autoscaler/processors/podinjection/scale_up_status_processor_test.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): cluster-autoscaler/processors/podinjection/scale_up_status_processor_test.go deleted in HEAD and modified in Export fake pods definition to a dedicated module. Version Export fake pods definition to a dedicated module of cluster-autoscaler/processors/podinjection/scale_up_status_processor_test.go left in tree.
CONFLICT (modify/delete): cluster-autoscaler/processors/podinjection/scale_up_status_processor.go deleted in HEAD and modified in Export fake pods definition to a dedicated module. Version Export fake pods definition to a dedicated module of cluster-autoscaler/processors/podinjection/scale_up_status_processor.go left in tree.
CONFLICT (modify/delete): cluster-autoscaler/processors/podinjection/pod_injection_processor_test.go deleted in HEAD and modified in Export fake pods definition to a dedicated module. Version Export fake pods definition to a dedicated module of cluster-autoscaler/processors/podinjection/pod_injection_processor_test.go left in tree.
CONFLICT (modify/delete): cluster-autoscaler/processors/podinjection/pod_injection_processor.go deleted in HEAD and modified in Export fake pods definition to a dedicated module. Version Export fake pods definition to a dedicated module of cluster-autoscaler/processors/podinjection/pod_injection_processor.go left in tree.
CONFLICT (modify/delete): cluster-autoscaler/processors/podinjection/enforce_injected_pods_limit_processor_test.go deleted in HEAD and modified in Export fake pods definition to a dedicated module. Version Export fake pods definition to a dedicated module of cluster-autoscaler/processors/podinjection/enforce_injected_pods_limit_processor_test.go left in tree.
CONFLICT (modify/delete): cluster-autoscaler/processors/podinjection/enforce_injected_pods_limit_processor.go deleted in HEAD and modified in Export fake pods definition to a dedicated module. Version Export fake pods definition to a dedicated module of cluster-autoscaler/processors/podinjection/enforce_injected_pods_limit_processor.go left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Export fake pods definition to a dedicated module
In response to this:
/cherry-pick cluster-autoscaler-release-1.30 /cherry-pick cluster-autoscaler-release-1.31 /cherry-pick cluster-autoscaler-release-1.32 /cherry-pick cluster-autoscaler-release-1.33
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@jackfrancis: #8273 failed to apply on top of branch "cluster-autoscaler-release-1.31":
Applying: Export fake pods definition to a dedicated module
Using index info to reconstruct a base tree...
M cluster-autoscaler/processors/podinjection/pod_injection_processor.go
M cluster-autoscaler/processors/podinjection/pod_injection_processor_test.go
Falling back to patching base and 3-way merge...
Auto-merging cluster-autoscaler/processors/podinjection/pod_injection_processor_test.go
CONFLICT (content): Merge conflict in cluster-autoscaler/processors/podinjection/pod_injection_processor_test.go
Auto-merging cluster-autoscaler/processors/podinjection/pod_injection_processor.go
CONFLICT (content): Merge conflict in cluster-autoscaler/processors/podinjection/pod_injection_processor.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Export fake pods definition to a dedicated module
In response to this:
/cherry-pick cluster-autoscaler-release-1.31
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@jackfrancis: #8273 failed to apply on top of branch "cluster-autoscaler-release-1.32":
Applying: Export fake pods definition to a dedicated module
Using index info to reconstruct a base tree...
M cluster-autoscaler/processors/podinjection/pod_injection_processor.go
M cluster-autoscaler/processors/podinjection/pod_injection_processor_test.go
Falling back to patching base and 3-way merge...
Auto-merging cluster-autoscaler/processors/podinjection/pod_injection_processor_test.go
CONFLICT (content): Merge conflict in cluster-autoscaler/processors/podinjection/pod_injection_processor_test.go
Auto-merging cluster-autoscaler/processors/podinjection/pod_injection_processor.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Export fake pods definition to a dedicated module
In response to this:
/cherry-pick cluster-autoscaler-release-1.32
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@jackfrancis: new pull request created: #8373
In response to this:
/cherry-pick cluster-autoscaler-release-1.33
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.