Jack Christensen comments

Results 346 comments of


                                            Jack Christensen

Use array's default scan in a custom type `Scan`

Are you using database/sql or pgx directly? Is this actually a custom type in PostgreSQL? Also, see the docs for the pgtype package and examine the tests in composite_test.go.

Fix args memory leak in rows.Close()

If setting rows.args to nil allows it to be GCed, then that implies that rows *cannot* be GCed for some reason. That would seem to be the ultimate issue. It...

Fix args memory leak in rows.Close()

I was considering whether the actual fix should be made in pgxpool, but after reviewing it further, I decided to expand on your suggestion. In particular, I also clear row.values...

Fix args memory leak in rows.Close()

@hrubymar10 No formal process. Just whenever there are a critical fix or a reasonable quantity of fixes. As it turns out, I fixed a long-standing bug today, so that triggered...

Unable to encode slice of string alias

The underlying issue is this part of the error message: `for unknown type (OID 16477)` _You_ know that it is an array of your enum type, but pgx doesn't. So...

inconsistent types deduced

> I've tried with a prepared statement in PG Admin and the same query works fine. I'm not sure what PgAdmin does, but can you try it directly in psql?...