Jack Christensen
Jack Christensen
At the moment there is no way to configure or disable this. I'm not opposed to changing this, but if something is to be done it should be more flexible...
> Sure, is it something you see living on the Config in pool.go? Yes.
Hmm... Good question. I'm not super eager to make `ConnResource` public. Though as you say, there isn't anything public that would give you the idle duration. Maybe something like: ```go...
Since `ShouldPingParams` is passed by value I would not expect there to be any allocations at all.
@DEliasVCruz I'm not opposed to adding configuration to control how health is checked. But I think that should be a separate interface from deciding *if* health should be checked. It's...
> This way users who just want health check disabled can pass false to the config option and be done with it With `ShouldPing` / `ShouldCheckHealth` they could assign a...
```go dbpool, err := pgxpool.New(context.Background(), os.Getenv("postgresql://pg:secret@exchange_rate:5432/exchange?sslmode=disable")) ``` I think you want to pass your conn string directly, not to get an environment variable with the name of your conn string....
@LiruMouse Do you have an example of this? I just created a simple test that sent a batch with 0 queries and it didn't crash. ```go batch := &pgx.Batch{} br...
@LiruMouse So, trying to read more results than queries were included in the batch? That's probably a bug in the application. I've added some additional checks to return a better...
Exposing `PreparedStatements` seems reasonable, but out of general principle I try to avoid expanding the interface. One potential issue is that it would expose cached statements as well as explicitly...