Jack Christensen comments

Results 371 comments of


                                            Jack Christensen

Application Hangs on `defer p.destructWG.Wait()` in Docker Environment

I can't reproduce with this example. But Pool.Close blocks until all resources are released. My guess is that a connection is not being released.

Application Hangs on `defer p.destructWG.Wait()` in Docker Environment

acquiredResources = 1 indicates that something has checked out a connection. The pool can't close until that connection is released. Unfortunately, I don't know of an easy way to find...

Add support for field name based composite type scanning

The fundamental difficulty with scanning by names in composite types is that composite field names are not included over the wire. They are sent positionally. So I don't think it...

Tracelog uses "time" when logging which can cause issues with JSON payloads

I don't think I want to change the default name. It's been called "time" for as long as there has been logging in pgx. But I'm open to making the...

Remove reliance on package unsafe

Seems reasonable to me. But @jan-dubsky wrote this code originally. @jan-dubsky what do you think?

Remove reliance on package unsafe

Okay. 👍 If someone wants to write the PR I think this is an easy merge.

`fatal error: concurrent map writes` in `EnumCodec.lookupAndCacheString`

`EnumCodec` (and any `Codec` for that matter) is not expected to be concurrency safe. How is this being used?

`fatal error: concurrent map writes` in `EnumCodec.lookupAndCacheString`

Every connection gets its own type map and set of codecs. EnumCodec is not concurrency safe -- but I wouldn't have expected it to be possible for it to be...

panic on scanning to slice of custom types

It works on v5.

Add support for OAuth

I wonder how this could even be tested? Is it possible to mock an OAuth provider or would tests need to actually spin up a real one?