Results 361 comments of Jack Christensen

Candidate solution: https://github.com/jackc/pgx/pull/2020

In general, I don't want to merge any performance optimizations without a benchmark that shows the improvement. That's especially true in this case because the text format was chosen on...

Does CockroachDB provide the `pg_type` and `pg_attribute` tables? That is where pgx is looking for the composite type definitions. See `*Conn.getCompositeFields`.

Thanks! I still don't see any what's going on. But there are a few things that jump out at me that might help narrow it down. 1. stdlib - whether...

There's nothing exactly wrong with handling `**T` in a `Scan` function, but it should be unnecessary. pgx typically can handle pointer to pointer automatically. See pgtype.TryPointerPointerScanPlan. I would expect it...

I don't see why not. It should just be another sql.Scanner and driver.Valuer to pgx.

@lefinal Can you provide an example usage that wouldn't work? I'm having trouble picturing it.

@lefinal I'm not sure get the entire picture, but my guess is it is similar to the issues with supporting `pgtype.Array[T]` in `database/sql` (see #1458 and #1662). Ideally, there would...

I don't know of any way to get a reference to a pgx object directly from a `*sql.Tx`. You could probably call `Raw` and `BeginTx` on the same `*sql.Conn` to...

The problem is unmarshalling the literal JSON string `"foo"` into a Go string removes the quotation marks. This is correct behavior. When encoding a string to a PostgreSQL `json` type,...