jacinta-stacks
jacinta-stacks
Closes https://github.com/stx-labs/core-epics/issues/82
I have added a bunch of comments that I will need to rip out before merging this. Mostly around where I am changing what was previously an "Expect" into a...
Clarity types (in clarity-types/src/types/mod.rs) should have their own error layer that could be then converted properly by the caller.
Convert “unreachable” runtime errors to a specific Unreachable error type that does NOT invalidate a block if it is hit
Should parse errors ever be converted to runtime errors? ASTError seems to only happen from calls in unit tests OR in clarity-cli. Related to https://github.com/stacks-network/stacks-core/issues/6692
Rename: - CheckErrorKind -> RuntimeAnalysisError - StaticCheckErrorKind -> StaticAnalysisError - StaticCheckError -> StaticAnalysisDiagnostic
Functions that can return both should return a new error type (e.g. ASTError) with two variants: Parse and Cost.
It is not clear why certain Value::err_uint values get returned throughout clarity and at what points they get returned. Perhaps map these magic numbers (1 or 2) to a variable...