stacks-core icon indicating copy to clipboard operation
stacks-core copied to clipboard

Chore/add custom error to clarity types

Open jacinta-stacks opened this issue 3 weeks ago • 1 comments

I have added a bunch of comments that I will need to rip out before merging this. Mostly around where I am changing what was previously an "Expect" into a Nonexpect error. Mostly cause they prob shouldn't ever happen/I don't know why they would actually invalidate a block. I also added an ExpectAcceptable and ExpectRejectable type.

Feedback would be good.

jacinta-stacks avatar Dec 10 '25 00:12 jacinta-stacks

Codecov Report

:x: Patch coverage is 71.54538% with 348 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 77.42%. Comparing base (c9003aa) to head (8f25aad).

Files with missing lines Patch % Lines
clarity-types/src/types/mod.rs 74.73% 72 Missing :warning:
clarity-types/src/errors/analysis.rs 34.44% 59 Missing :warning:
stackslib/src/chainstate/nakamoto/signer_set.rs 55.68% 39 Missing :warning:
...ackslib/src/chainstate/nakamoto/coordinator/mod.rs 47.82% 24 Missing :warning:
...y/src/vm/analysis/type_checker/v2_1/natives/mod.rs 25.80% 23 Missing :warning:
clarity-types/src/types/signatures.rs 83.13% 14 Missing :warning:
clarity/src/vm/analysis/type_checker/v2_1/mod.rs 26.66% 11 Missing :warning:
.../src/vm/analysis/type_checker/v2_05/natives/mod.rs 28.57% 10 Missing :warning:
clarity/src/vm/functions/sequences.rs 78.72% 10 Missing :warning:
clarity/src/vm/analysis/type_checker/v2_05/mod.rs 18.18% 9 Missing :warning:
... and 20 more

:x: Your project check has failed because the head coverage (77.42%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6751      +/-   ##
===========================================
- Coverage    77.90%   77.42%   -0.48%     
===========================================
  Files          580      580              
  Lines       361187   361490     +303     
===========================================
- Hits        281374   279877    -1497     
- Misses       79813    81613    +1800     
Files with missing lines Coverage Δ
clarity-types/src/errors/mod.rs 76.34% <100.00%> (+0.78%) :arrow_up:
clarity-types/src/lib.rs 100.00% <ø> (ø)
clarity-types/src/representations.rs 85.49% <ø> (ø)
clarity-types/src/tests/representations.rs 75.00% <ø> (ø)
clarity-types/src/tests/types/mod.rs 97.07% <100.00%> (+0.02%) :arrow_up:
clarity-types/src/tests/types/serialization.rs 98.27% <100.00%> (-0.04%) :arrow_down:
clarity-types/src/tests/types/signatures.rs 99.12% <100.00%> (ø)
...rc/vm/analysis/type_checker/v2_1/natives/assets.rs 98.36% <100.00%> (ø)
...lysis/type_checker/v2_1/natives/post_conditions.rs 97.27% <ø> (ø)
clarity/src/vm/contexts.rs 92.24% <100.00%> (+0.01%) :arrow_up:
... and 50 more

... and 91 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c9003aa...8f25aad. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 10 '25 01:12 codecov[bot]