dt-mergebot icon indicating copy to clipboard operation
dt-mergebot copied to clipboard

Unreviewed label is confusing and its timeline should improve

Open elibarzilay opened this issue 5 years ago • 1 comments

In case where am owner approval was given but a maintainer approval is needed, the code sees that there is no approval and goes into the unreviewed timeline and the Unreviewed label is obviously confusing. See for example DefinitelyTyped/DefinitelyTyped#50161 (which I captured to test when this is fixed).

elibarzilay avatar Jan 01 '21 19:01 elibarzilay

approverKind !== "maintainer" would fix this? https://github.com/DefinitelyTyped/dt-mergebot/pull/254#discussion_r537579951

jablko avatar Jan 01 '21 20:01 jablko