Results 153 comments of jabdoa2

Yeah we can definitely use something like LightStack in the Blinkenlights device. I would not merge this logic into lights for a few reasons. First you probably still want to...

> Also, the name blinkenlights... are we set on this? It doesn't seem to be very informative for what this actually is. MultiColorLights, MultiLights, DynamicLights, (I'm sure others have better...

Looks good overall. I like that you included tests. Some small things I would like to add/change: - Synchronization of blinkenlights - Methods to add/remove entries instead of direct access...

also fix #557 at that point

Hi evilmopey, Pinball machines are multiplayer machines. Every player has multiple ball (usually 3) and player take turns (player 1 ball 1, player 2 ball 1, player 1 ball 2...

The four counting strategies are a bit tricky but each of them was used in a certain area of pinball machines. min_virtual_physical = locked ball are counted virtually. If another...

Can't find the PR. Can you post a link to the PR or to your branch?

I like the idea to have fixed length steps in shows. You could use flasher_player in your show (flashers section) to achieve constant length flashes. However, that show step would...

Overhead should be fine since the usual delay will be larger than 1ms and our templates should a lot faster than that.

@avanwinkle i checked your branch. It look pretty clean and straightforward to me. I like it! Some small remarks: - I guess i would like to just re-purpose the "duration"...