James Gaboardi comments

Results 433 comments of


                                            James Gaboardi

testing for legendgrams?

> `pysal.contrib` is over, and we need to use the standard geopandas tools to plot, I think `geoplot` from `pysal.contrib.viz.mapping` isn't even being used in the testing. Can we just...

usage of `intensity` within `random.py` distributions?

Yes, that makes sense. > The intensity is returned from the parse function just in case future functions find it easier to work with that than with the sizes. Right...

`nan_dot` is undefined

@TaylorOshan Do you have any insight on this?

Seems that it was in the [initial commit](https://github.com/pysal/spglm/commit/6d6607201cd37aa91ef8581fddf8f0213a5d6e30#diff-8a3053a35fc794b288420f7343bfbc575c18bc834c223c2aae201e0adcfdd5c0R343) as being [imported from `statsmodels.tools.tools`](https://github.com/pysal/spglm/commit/6d6607201cd37aa91ef8581fddf8f0213a5d6e30#diff-8a3053a35fc794b288420f7343bfbc575c18bc834c223c2aae201e0adcfdd5c0R7)

unused lines of code in `glm.py` and `varfuncs.py`

See more conversation for `spglm/varfuncs.py#L117 in https://github.com/pysal/spglm/pull/40#discussion_r1355249720

Notebook `glm_speed` causing issues when converting to markdown

@weikang9009 @darribas I was able to fix the `UnreadableNotebook` error and will push up a PR later today. pysal/notebooks#52

rename `master` to `main`

Following the resolution of #39 and merge of #32.

revisit docstring and doctest updates

@pedrovma, Let me know if this of interest. If it is not something you are interested in then there's no hard feelings from me. We can close out the PR...

Accessibility Function

@ljwolf, It looks like @lenkahas has addressed your comments (from what I can tell). Is there anything preventing this merge?

BUG: plot_local_autocorrelation colors do not match between subplots

@olenaboiko303 Can you copy & paste the code you are running? It's cumbersome to troubleshoot from an image of code.