legendgram icon indicating copy to clipboard operation
legendgram copied to clipboard

Published 20 hours ago • verified publisher icon pysal

testing for legendgrams?

Open jGaboardi opened this issue 6 years ago • 4 comments

@ljwolf Should legendgram/test_legendgram.py be moved into a new tests/ directory?

jGaboardi avatar Aug 26 '18 01:08 jGaboardi

sure; better to be consistent. In theory, I'm fine with having small packages have no dedicated test directory, but there's no reason not to be consistent.

ljwolf avatar Aug 28 '18 00:08 ljwolf

Further, as @martinfleis notes, we need to update the tests. pysal.contrib is over, and we need to use the standard geopandas tools to plot, I think.

ljwolf avatar Apr 09 '20 16:04 ljwolf

  • since legendgram is moving to inside splot, should we work on updating the tests once it's in there?
  • @slumnitz, are you considering migrating splot testing from TravisCI to GitHub Actions? If yes, I can help out with that.

jGaboardi avatar Apr 09 '20 18:04 jGaboardi

pysal.contrib is over, and we need to use the standard geopandas tools to plot, I think

geoplot from pysal.contrib.viz.mapping isn't even being used in the testing. Can we just remove that import in #11 ?

jGaboardi avatar Apr 09 '20 22:04 jGaboardi