James Gaboardi

Results 433 comments of James Gaboardi

***re: pacakage install*** For some packages (e.g. `spopt` and [`spaghetti`](https://github.com/pysal/spaghetti/blob/main/.github/workflows/testing.yml)), merely [checking out the repo is enough](https://github.com/pysal/spaghetti/blob/17a411cb88dfe1532e01b83bdb0cca28cdd926a5/.github/workflows/testing.yml#L46). However, this is not the case most of time (e.g. [`tobler`](https://github.com/pysal/tobler/blob/1439e4268ec18df382ba1f5a78dcec578639a5ae/.github/workflows/unittests.yml#L65) and [`momepy`](https://github.com/pysal/momepy/blob/36b13f827200c694ecbcff54545b227d526959b6/.github/workflows/tests.yaml#L53))....

Probably best to start with a `FutureWarning` that the namespace will change, even though only slightly.

@martinfleis Do you have any input on this since `momepy` is using both `Gini` and `Theil`?

Should we disable doctests for the `_indices.py` module to get CI green?

@sjsrey shall we pick this back up again to get CI green?

Looks like have a [fresh exception](https://github.com/pysal/inequality/actions/runs/9126045463/job/25093477102?pr=69#step:4:472) being thrown by bleeding edge `pandas` now. If it's not something to simply let ride, we can open a new ticket for it. ```...

> Should we disable doctests for the `_indices.py` module to get CI green? We still need to address these failures, either by skipping or updating.

Seems that it's actually `pre-commit` that's complaining. Did you run `ruff check inequality` locally before pushing?

pre-commit.ci run

pre-commit.ci autofix