James Gaboardi

Results 433 comments of James Gaboardi

@nickbearman Just now I was able to open the binder and run the P-Median notebook, both from the link in the `README` and the link in the tutorial page. I...

@sjsrey Can you do a `conda list` and paste up the environment + OS, etc.?

The two tests that are currently failing for most environments ([`test_adbscan.py::ADBSCAN_Tester::test_adbscan`](https://github.com/pysal/esda/actions/runs/3457868371/jobs/5771724315#step:7:102) and [`test_adbscan.py::Get_Cluster_Boundary_Tester::test_get_cluster_boundary`](https://github.com/pysal/esda/actions/runs/3457868371/jobs/5771724315#step:7:108)) are [passing in Python 3.7](https://github.com/pysal/esda/actions/runs/3457868371/jobs/5771724241). The difference here seems to be that the Python 3.7 environments are...

@sjsrey I have tracked down the bug and found the fix. In [`scikit-learn==1.1.0` some validation steps were added](https://github.com/scikit-learn/scikit-learn/blob/f3f51f9b6/sklearn/cluster/_dbscan.py#L362-L393) that were not present in [`scikit-learn==1.0.2`](https://github.com/scikit-learn/scikit-learn/blob/1.0.2/sklearn/cluster/_dbscan.py#L363). The one giving trouble specifically is...

I will put in a PR for that second solution, but can easily swap the first if that's better.

I'm also seeing no major/unexpected issues thus far.

No, this is not currently possible due to the historic structure of `pysal.network` (`spaghetti`'s predecessor) and the utilization of the [`djikstra `](https://github.com/pysal/spaghetti/blob/7dfb5e36c141086aa080c596fca648bbbe82af86/spaghetti/util.py#L155) algorithm). There has been discussion[^1][^2] for overhauling &...

Nope, I can't think of anything. Let's nix it.

@martinfleis Was there an earlier problem with this calculation?

@martinfleis I will try to give this some attention over the weekend.