James Gaboardi
James Gaboardi
:shipit: 🚀
> I have no clue how to review this beast. > > @jGaboardi I know it is late now but it would be better to split changes of docstrings from...
Yep, that was my plan. Maybe even ruff only 1 or 2 files at a time depending on the amount of changes made.
@knaaptime Seems like we could simply add in the keyword and pass directly into the plotting function. IMO, no tests are even needed since it's a GeoPandas thing at that...
Seems also to be related to https://github.com/pysal/spaghetti/issues/731.
xref https://github.com/pysal/libpysal/pull/533#issuecomment-1636058892 ### re: plotting tests I've had success with matplotlib's decorator – [image_comparison](https://matplotlib.org/stable/devel/testing.html#writing-an-image-comparison-test) We should probably open a specific issue for this.
Are we thinking about getting rid of aliased import altogether (in our code base, too) or only in the example/demo notebooks?
We'll go ahead and close this then, and we can reopen if needed in the future.
@martinfleis Can you add the information mentioned in today's meeting about the GHPyPI org credentials?
I think this can closed now that we no longer support Python 3.9 --> xref #1305. Please re-open if needed.