spaghetti icon indicating copy to clipboard operation
spaghetti copied to clipboard

remove `geom_col` argument in `element_as_gdf()`?

Open jGaboardi opened this issue 2 years ago • 2 comments

#720 introduced a small ruff regression where the geom_col keyword is no longer used in util._arcs_as_gdf(), which triggers a ruff failure in pre-commit.

The thought here is that maybe we should remove the geom_col argument in element_as_gdf()? And always default to "geometry".


EDIT

  • deprecated in #724
  • remove in v1.8.0

jGaboardi avatar May 08 '23 18:05 jGaboardi

Can you think of a use case when you want the column to be called differently and it couldn't be done via an intermediate rename_geometry call?

martinfleis avatar May 08 '23 18:05 martinfleis

Nope, I can't think of anything. Let's nix it.

jGaboardi avatar May 08 '23 18:05 jGaboardi