James Gaboardi
James Gaboardi
This is resolved in the current release.
Closed by #114.
@SimonPop Hello! Thanks for adding to this thread before starting the work! And *MANY* thanks for considering spending your time & energy contributing to OSS. > I would like to...
Also, checkout [`spopt`](https://github.com/pysal/spopt) if you are interested. We've had much more development over there in the past several years.
Tests are passing locally. [Failure](https://github.com/pysal/libpysal/actions/runs/3301624340/jobs/5447307217#step:4:1744) due to a fresh issue in `geopandas` through `fiona`.
> Can we test this? Probably a good idea to... Let me try to carve out some time to look into it unless you already have an idea?
In order to exactly test this we need to know of a situation where "there are corner cases when silhoutte for two clusters are exactly the same" (see [here](https://github.com/pysal/spopt/issues/57#issue-650666401)). I...
> Out of curiosity, where is Rtree used in spopt? Seems as it is actually not even being used in `spopt` at all. Suppose I can simply close out that...
> Is it used anywhere? Is there a value in keeping it around or is that something that could be deprecated? Good question...
@JamesParrott make sure the files you are pushing to this PR are formatted and linted properly. Currently, [pre-commit is failing](https://results.pre-commit.ci/run/github/88918063/1702587594.w7l93gwFQ06H4HvxjygQYw) due to this.