j-schultz

Results 13 comments of j-schultz

It's not part of this PR, but I found that the CMake build system is also doing dubious stuff here that pessimizes x64 builds on arm64: https://github.com/xiph/opus/blob/ccaaffa9a3ee427e9401c4dcf6462e378d9a4694/cmake/OpusConfig.cmake#L42 From my understanding,...

> so the issue is cross compiling to x64 on a m1/m2 mac for cmake? Correct. And probably the other way around, too (missing NEON optimizations when cross-compiling for arm64)

As I said, just running the webcam example that ships with Qt (`multimedia/declarative-camera`, using Qt 5.15 here) itself is enough to trigger the bug. Since Webcamoid is written in Qt,...

This is also still happening for me on the Windows desktop client, version 5.1.1. ![image](https://user-images.githubusercontent.com/46443117/197223166-de35f970-8d15-456a-a897-0a82b319ed2f.png)

Which version of opusdec did you test against? Because with my own code (which I cannot share in full, but if required I can extract the opus encoder and decoder...

In fact this looks like it's the same report as #239.

Not sure if it's exactly the same issue as described here, but using latest master (bce1f392353d72d77d543bb2069a044ae1045e9d) and the included `opus_demo` tool as follows: ``` ./opus_demo -e audio 48000 1 32000...

`__builtin_unreachable` is not part of the C standard and not portable (as indicated by the double-underscore). MSVC offers `__assume(0)` as an alternative, but there also needs to be an alternative...

You could give pull request #88 a try, which adds Windows and CMake support.