Justin Berman

Squashed and rebased

Appreciate you taking this on :) My general view is the data displayed in the block explorer should be very intuitive and lean toward simple for noobs. > Add: Number...

> By "currently spendable", you mean first spendable at tip index + 1 (AKA next block), right? Hah, this terminology is going to be tough forever. I think we're saying...

> I propose that Monero replaces these binary strings with one of the following options: > 1. Full JSON > 2. Full binary > 3. Hexadecimal encoded binary within JSON...

> Sounds good but is there a reason to add `as_hex` alongside a binary version? Agree, would seem like a nice to have if someone requests it, not a required...

Also looking at the other spot `add_block_as_invalid` is called: https://github.com/monero-project/monero/blob/caa62bc9ea1c5f2ffe3ffa440ad230e1de509bfd/src/cryptonote_core/blockchain.cpp#L4288-L4293 since `check_tx_inputs` can be false at one point and become true ([example](https://github.com/monero-project/monero/pull/9135#discussion_r1538682499)), the cache behavior for invalid blocks looks incorrect....

Hmm, actually it would seem the block's `prev_id` would need to be different for `check_tx_inputs` to have a different result (higher height = different prev id), which means the block...

Adding to above, @MrCyjaneK I'm not sure what could be causing your slowdown yet and wasn't able to repro your issue with the CLI. I asked @plowsof to see if...

> The 2x was seen not in total time to sync wallet as we are testing here, but rather in part of the scanner code. which i will confirm tomorrow...

> my tests show that there was (literally) 0 difference between master and this pr when syncing over lan Ya, this isn't surprising. I was referring to clearnet as in...