Justin Berman

Results 196 comments of Justin Berman

Apologies this has gotten a bit messy... - #4051 isn't a dependency for this PR; it's strictly for the scan tx feature in the GUI. - https://github.com/monero-project/monero/pull/8619 right now has...

Quality testing thank you @plowsof :) > One time after unlocking the wallet , i noticed a 'wait / forcequit' message box Can you repro this? That shouldn't happen; processing...

Good eye, I noticed some jank on my end with a larger wallet sometimes too. How does the latest look on your end? I updated the Monero PR as well.

In line with @tobtoht's comment [here](https://github.com/feather-wallet/feather/issues/72#issuecomment-1405602142), I think the GUI will also need a deeper pass to more effectively protect against exfiltration of the spend key and plaintext password when...

Yep, this PR is WIP and not ready for testing yet since the latest overhaul to 8619

@selsta this PR is ready for review (no longer WIP). Sorry I should have made that clearer in a follow-up comment.

> with the transactions window open Do you mean when the GUI is locked while you're on the transaction window? Can you screenshot the UI? If this is just something...

Is it spamming logs with mega noise or just a couple like those above? The GUI probably shouldn't be attempting to do those reads while the wallet is locked in...