Justin Berman

Results 44 issues of Justin Berman

### Problem When a daemon is in the "fluff" epoch and a user submits a tx to the daemon, the tx doesn't get published via zmq's `txpool_add`. Reported by @TrasherDK;...

Pairs with: https://github.com/LedgerHQ/app-monero/pull/110 I tested sending/receiving mainnet txs + tested sending/receiving testnet txs (post-fork), both exporting view key and not.

- Defensive change from `return` to `continue` to ensure pool pruning executes to completion. - Ensure tx pool weight doesn't underflow. - Will propose a fix in PR #8076 that...

When self-spending to a subaddress, a view-only wallet that had not already imported key images prior to scanning the tx will misinterpret the change in the tx as a "payment"....

### Overview My wallet is connected to my node via tor, my node uses the tx proxy over tor. This happened the other day: 1. I created a tx in...

UPDATE Apr 11: collaborated with @paulshapiro to add endpoints to create or retrieve subaddresses (`/provision_subaddrs`, `/upsert_subaddrs`, `/get_subaddrs`). Also in line with @ndorf 's comment to support this [here](https://github.com/monero-project/meta/pull/647#issuecomment-1007852519). # Overview...

## Overview This is a simplified approach to "binning" done purely in the client. It's meant to demonstrate a PoC that can be implemented in `wallet2` today, while iterating toward...

Related to (and should hopefully solve) #8531 When using `scan_tx` to re-scan a tx, `process_new_transaction` will re-add received outs as a new (duplicate) incoming transfers with amount=0. This PR ensures...

Bringing this commit by @TheCharlatan over from #30 also :)