Alexey Zapparov

Results 347 comments of Alexey Zapparov

I have refactored fetch class implementation, and removed IPC based on pub/sub. That should eliminate sidekiq-throttled from the equation in the above problem. But will be happy to debug further...

You can use multi-rule on shared pool: ``` ruby Sidekiq::Throttled::Registry.add( :third_party_apis, threshold: [ { limit: 10, period: 1.minute }, { limit: 2, period: 10.seconds, key_suffix: ->(...) { ... } }...

Should be fixed in v1.0.0.alpha - I have removed cooldowns.

> re: slug logic, the server decided to [slugify anyway](https://github.com/getsentry/sentry/blob/b5f2368068033e3a32b049cba4ff2d7f20612f48/src/sentry/monitors/models.py#L256-L261) so it won't matter if we expose custom slugify logic on the SDK. If I read Python correctly, it only...

My tests were randomly passing randomly failing. Adding a freeze helped to nail down that Sentry helper was changing configuration inplace - thus specs became order-dependent

@Schniz is this something you can think might be merged, or should I close this PR and stop checking it?

> In trying to rerun the tests but I’m afk (parental leave) so I’m not sure why it failed. We can ignore clippy Oh, congrats!!! Will try to make build...

That looks amazing! Thank you! Will take me some time reviewing though... :D

IMHO using `$/` is bad - it's less obvious than `"\n"`. More than that, `$/` can be redefined, so the code may become broken.