http icon indicating copy to clipboard operation
http copied to clipboard

Add .retriable feature to Http - Rebased

Open tomprats opened this issue 1 year ago • 4 comments

Rebase of https://github.com/httprb/http/pull/598 with:

  • hashrockets removed
  • rubocop formatting updates
  • creating a response with uri option

I don't understand the internals super well, but the changes I made off of the original were minor enough to not really change any actual functionality. Tests and cops all pass!

tomprats avatar Jan 05 '24 21:01 tomprats

I had some time, so I ended up rebasing and fixing the lint and test errors.

@ixti would you mind taking a look again?

tomprats avatar Jan 05 '24 21:01 tomprats

That looks amazing! Thank you! Will take me some time reviewing though... :D

ixti avatar Jan 15 '24 01:01 ixti

@ixti Any luck?

tomprats avatar Feb 05 '24 19:02 tomprats