Alexey Zapparov

Results 309 comments of Alexey Zapparov

Will wait with final decision until real case scenario appears.

Re: Style/RedundantCurrentDirectoryInPath I prefer consistency. It is pretty weird to me that rubocop's default for `rescue` is to be explicit, while for `require_relative` it's implicit. Let's just disable this cop....

`sidekiq_class_attribute :sidekiq_throttle_push_back` will define a new singleton class method, so the usage will look like: ``` ruby class MyJob include Sidekiq::Job include Sidekiq::Throttled::Job sidekiq_throttled_push_back :enqueue end ``` Naturally, we should...

I have no strong feelings about `push_back` vs `requeue_strategy`. I just don't like over-use of *strategy* in names (easy to confuse with Throttled::Strategy). Probably simply: `sidekiq_throttled_requeue_with`? Also, just realized, that...

@lavaturtle @woodhull thanks for the amazing PR. I will try to go through it today-tomorrow. Sorry for being unresponsive (was really overwhelmed with some work lately - but slowly getting...

The only issue I'm scratching my head about right now is the Sidekiq-Pro support. Can't figure out how to make sure it works correctly. Thus thinking on skipping it's support...

I'm gonna refactor the way scheduling strategy is stored, and will incorporate this PR as part of v2.0.0 release which I will work on next weeks. Couple of heads up...