Alexey Zapparov
Alexey Zapparov
> The response includes a `Content-Length` and `CONTENT_LENGTH` header. It seems like http.rb is treating them as equivalent (probably due to the normalizing), but I believe it should treat them...
I'm not sure I understand why existing code won't work. You can log request before it has been sent. Not sure what benefits `on_error` will provide.
I still don't think it's a good idea to introduce the change that will be useful only for logging feature.
``` ruby HTTP.post("https://httpbin.org/post", :form => { :grant_type => "client_credentials", :client_id => "abc", :client_secret => "def", :resource => "xyz" }) ```
We don't support Socks proxy yet.
/cc @httprb/core
So far I am using following kludge (monkey-patch) in my code: ``` ruby module HTTP class URI def join(uri) self.class.new(@uri.join(uri)) end def normalize self.class.new(@uri.normalize) end def omit(*components) self.class.new(@uri.omit(*components)) end def...
Was thinking of the same, but something dragged me away from that idea. Would like to outline couple of things though: - using it will disallow to run specs without...
> This is already the case Oh. Indeed. Then, I guess we should switch. Absolutely agree on second part too.
@singpolyma-shopify thank you for the PR. I really like the proposed changes, but we need to make sure they work as expected when parser's buffer contains more data than requested...