http icon indicating copy to clipboard operation
http copied to clipboard

Published 20 hours ago • verified publisher icon httprb

Satisfy IO#readpartial API

Open singpolyma-shopify opened this issue 4 years ago • 2 comments

IO#readpartial allows for a second "outbuf" param which some streaming usages expect, so support it here to allow using response bodies anywhere IO can be.

singpolyma-shopify avatar Aug 24 '20 21:08 singpolyma-shopify

@singpolyma-shopify thank you for the PR. I really like the proposed changes, but we need to make sure they work as expected when parser's buffer contains more data than requested size :D

ixti avatar Sep 22 '20 01:09 ixti

@ixti fixed

singpolyma-shopify avatar Sep 22 '20 14:09 singpolyma-shopify