Alexey Zapparov

Results 309 comments of Alexey Zapparov

@Kache thank you, sorry for being a bit slow on this, will tackle your PR this weekend.

@janko-m generally I totally agree. :D But I think we should provide swap-able interface for things like this.

So, let's keep this open for now.

Although I see how that is not very cool. I don't think that swallowing errors and silently returning empty body is good idea... It's not client's responsibility to handle that...

What I mean is, let's say our server behaves like this: ``` ruby # frozen_string_literal: true require "socket" server = TCPServer.new(8080) while (socket = server.accept) req = socket.gets[%r{^GET /([^ ]+)},...

@wasifhossain Oh. Great idea. This can be in fact managed by allowing to pass `:formatter`.

One thing to keep in mind is that some responses (as well as requests) can't have body easily (and efficiently) log-able (like streaming ones). We should think about that.

Yeah. #463 needs to be implemented.

I'll take a look this weekend.

My 2 cents. Once valid (working) address found - it should probably be cached at least for the given TTL (probably can be configured) so that next request to the...