Ameer Hamza
Ameer Hamza
cc: @amotin, @freqlabs.
Thanks, @richardelling for your review, I have updated the code according to your suggestions.
cc: @amotin, @freqlabs
@freqlabs I just added an updated version and split my work into multiple commits. cc: @amotin
@tonyhutter thank you so much for testing these patches. Since spare vdevs do not have a label, I think it would require some extra work to support hotplugging for spares,...
@tonyhutter Thank you for your description. I debugged the issue and it seems to be related to virtio disks. Vdev should have devid "/dev/disk/by-id", so it can be identified during...
@tonyhutter you are right, hotplugging of spare is indeed not supported in this patch since it does not contain a label that we use to identify other vdevs. @freqlabs -...
@behlendorf, @tonyhutter It would be appreciated if you guys can provide feedback or tag relevant guys here to review this PR. These patches are very critical for our TrueNAS BETA...
@tonyhutter Thank you so much for your review and for verifying it on your hardware. I have incorporated your feedback into this PR.
Thank you @freqlabs. I have incorporated your suggested changes.