Ameer Hamza

@tonyhutter It would be nice to have these commits as well: https://github.com/openzfs/zfs/commit/a7bd20e309a4b45b18b1da8e379f5826debe4870 https://github.com/openzfs/zfs/commit/c50b3f14d33cd469af47e16f0c6c76f2b4b5158e https://github.com/openzfs/zfs/commit/577d41d3b2e4b37f51270c399c85b2708e21238a. Do let me know in case of any issues or conflicts.

@tonyhutter We would also want to add https://github.com/openzfs/zfs/pull/13476/commits/f163a44d78b5b098e8cab800709d2423530f8cd7 as well, which is an improvement over https://github.com/openzfs/zfs/commit/a7bd20e309a4b45b18b1da8e379f5826debe4870. Thanks!

@tonyhutter https://github.com/openzfs/zfs/commit/f163a44d78b5b098e8cab800709d2423530f8cd7 fixes huge delays and spikes during writes that were introduced by the https://github.com/openzfs/zfs/commit/a7bd20e309a4b45b18b1da8e379f5826debe4870, i.e., https://github.com/openzfs/zfs/commit/f163a44d78b5b098e8cab800709d2423530f8cd7 is the correct version of https://github.com/openzfs/zfs/commit/a7bd20e309a4b45b18b1da8e379f5826debe4870. Sorry for the delayed request but I...

@amotin, @tonyhutter, @asomers - This patch works for both Linux and FreeBSD since both zed and zfsd use the same IOCTL to make the disk online.

Thanks, @asomers for your response. To clarify, this is easily reproducible on 25 top-level vdevs, each of which has a two-way mirror. I am not very deep in that part...

Thanks. That's the intention of this patch. When ```zpool_vdev_online()``` is called from zed/zfsd, we now manually detach the spare vdev if resilvering is not necessary.

> When cachefile property is set to none, do [-d] or [-O] options require the -e option? or is that automated as well? @akashb-22 - Considering `libzfs` is able to...

@akashb-22 - I have made some adjustments to automate the scenario you mentioned. Can you give it a try now?

@amotin, @freqlabs, @anodos325.

Thanks, @youzhongyang. @amotin suggested some modifications internally, I am testing those and will also add the test case.