Ivan Maidanski
Ivan Maidanski
/cc @jeaye @plajjan
> This option was particularly problematic because it's actually [a standard cmake variable](https://cmake.org/cmake/help/latest/variable/BUILD_SHARED_LIBS.html) so declaring it as an option here forces it ON globally for the whole project. This means...
Okay, more clear now. As I understand the following should be done at least: 1. Prefix `BUILD_SHARED_LIBS` (with `BDWGC_`) 2. Pass `SHARED` or `STATIC` every `add_library` depending on `BDWGC_BUILD_SHARED_LIBS` (as...
> I'll make that change today. Wait, let's fully understand the logic first.
> Okay, more clear now. As I understand the following should be done at least: So, we define `BDWGC_BUILD_SHARED_LIBS` as option with ON by default. But the client could also...
> But these two cases are not distinguishable in the cmake script because BDWGC_BUILD_SHARED_LIBS is ON by default. AI suggest the following code to distinguish between unset and set default:...
Okay, @BenLeadbetter, please update the patch. We might need a warning in case 'cmake -D BUILD_SHARED_LIBS=OFF'
> if(DEFINED MY_FEATURE AND NOT "${MY_FEATURE}" STREQUAL "") No, the code provided by AI is not working correctly. The condition is always true.
Hello @BenLeadbetter. After considering pros and cons, I've decided to apply part of your patch addressing exactly BUILD_SHARED_LIBS issue. Without backward compatibility. See PR #825. `BUILD_SHARED_LIBS` option was introduced in...
Closing this PR in favor of #825