Ivan Maidanski

Results 817 comments of Ivan Maidanski

MidnightBSD: https://github.com/MidnightBSD/mports/pull/120 - merged

Sagemath: https://github.com/sagemath/sage/pull/41241

Spack: https://github.com/spack/spack-packages/pull/2636 - merged

CheriBSD: https://github.com/CTSRD-CHERI/cheribsd-ports/pull/226

FreeBSD: https://cgit.freebsd.org/ports/commit/?id=ee16a368b083159d1d0ec9cb4d147ea2f55e1eca (done by Rodrigo Osorio) (mirrored on Github: https://github.com/freebsd/freebsd-ports/commit/ee16a368b083159d1d0ec9cb4d147ea2f55e1eca)

Could you please refer to some guide or popular project following this naming convention?

AI output: > Prefixing (Optional but Recommended): For larger projects or when there's a potential for name clashes with external CMake modules, consider prefixing options with the project name or...

But at the same time as mentioned in https://cmake.org/cmake/help/latest/variable/BUILD_SHARED_LIBS.html > CMake does not define BUILD_SHARED_LIBS by default, but projects often create a cache entry for it using the option command

Please update the patch based on the comments above. Or let's discuss more if you don't agree.