Ivan Maidanski comments

Results 817 comments of


                                            Ivan Maidanski

gctest fails on Serenity OS

Having the proposed patches, we do not need https://github.com/SerenityOS/serenity/blob/master/Ports/bdwgc/patches/0005-Make-the-collector-build-with-threads.patch, right?

SIGSEGV in static multi-threaded build with redirect malloc

Note: we cannot redirect `GC_malloc` (`GC_malloc_kind_aligned_global`) to `sbrk` if GC is not initialized because `sbrk` is not available.

SIGSEGV in static multi-threaded build with redirect malloc

Same observed on CheriBSD.

Switch GC_incremental and fullGC mode on/off at runtime

Okay, I will review it next week.

Switch GC_incremental and fullGC mode on/off at runtime

> were there any issues identified with it? Please add test code to gctest. I am not sure the code is working. Also, please see byild failures: * https://ci.appveyor.com/project/bdwgc/bdwgc/builds/52534894 *...

weakmaptest or disclaimtest failure if malloc redirect and gc-debug

Somewhat related: #613

weakmaptest or disclaimtest failure if malloc redirect and gc-debug

Source: master (abbe389) Build: https://github.com/bdwgc/bdwgc/actions/runs/19274603415/job/55111265890 Host: Linux/x86_64 Command: `zig build -Dtarget=native -Dlinkage=static -Denable_cplusplus=true -Denable_gc_assertions=true -Denable_gc_debug=true -Denable_munmap=false -Denable_redirect_malloc=true -Denable_rwlock=true test`

weakmaptest or disclaimtest failure if malloc redirect and gc-debug

Reproduced disclaim_test failure locally ("h"). Source: release-7_6 (b5c41e957). Host: Ubuntu/x86_64 Command: `./configure --enable-redirect-malloc --enable-gc-debug --enable-cplusplus --enable-gc-assertions && make -j check CFLAGS_EXTRA="-D _FORTIFY_SOURCE=2"` ``` (gdb) bt #0 __pthread_kill_implementation (no_tid=0, signo=6, threadid=)...

weakmaptest or disclaimtest failure if malloc redirect and gc-debug

The solution could be to skip `backtrace` call if called from malloc() when the later is called from libc.