Iván Valdés Castillo

Results 430 comments of Iván Valdés Castillo

> -release @serathius, I had a hard time finding this message in this pull request; it has a lot of activity. I see that you suggested a change that will...

Hi @krijohs, thanks for your pull request. Ideally, we would want to discuss the issue and possible solutions before a pull request. Could you please open an issue so other...

@krijohs, could you please rebase your branch with the latest upstream `main` branch? I'm having issues running the tests because the base is outdated. Thanks :)

> What is interesting in cli it works conversely - it fails with integer, but works with duration string @BBQing, can you provide an example or a reference to this...

Thanks for the explanation, @BBQing. The issue is that this is not the only duration that I saw in your pull request. So, perhaps we should address the rest of...

@BBQing, I see your point. Thanks for the clarification. Additionally, upon reviewing the pull request, it appears to be backward compatible.

For now, let's keep it as you proposed, and let's not consider further changes to the schema for 4.0.

Hi @ronaldngounou, there are a couple of broken links in the document you pushed. Refer to the Prow job failure: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/etcd-io_etcd/20796/pull-etcd-verify/1979810317445632000# > Found broken reference (Prow -> ) at /home/prow/go/src/github.com/etcd-io/etcd/Documentation/contributor-guide/prow_jobs.md:5...

@upodroid, in the etcd repos we use DCO. If you sign your git commit the check will pass. Thanks for this initiative! /ok-to-test