Iván Valdés Castillo
Iván Valdés Castillo
Hi @kstrifonoff, thanks for the pull request. I'm respectful to the original contributor who asked to work on this. Our guideline is to re-assign after a week of no answer...
/ok-to-test
> I’m not sure what kind of end-to-end test should be done here. What should it cover? It’s also not clear to me what the current end-to-end test actually checks....
I'll take the second one: > All the deprecated fields are not correctly marked.
> The deprecated comment/description isn't consistent across "help/flag description/field comment" etc. For example, for --experimental-txn-mode-write-with-shared-buffer, we only added "deprecated ..." in the help.go, but not in the field comment, nor...
I believe we can now close this issue, as all tasks have been completed. Unless I'm missing something?
Closing. I believe there are no remaining action items. Please feel free to re-open otherwise.
cc. @jmhbnz @ahrtr @serathius. Please let me know your thoughts.