Ivan Ka

Results 538 comments of Ivan Ka

That's strange. I haven't been able to reproduce this on my end. Can you confirm if your ExternalDNS instance is actually running version 0.18? The only difference, I'm not using...

Another thing, if you see no version in logs, this is the line in code https://github.com/kubernetes-sigs/external-dns/blob/111df9f1fb4c0ee63823cca7dd57ac1a7815104e/controller/execute.go#L98, it could be that it's an older version of a service. Worth to review...

The work make sense to me. I’m not sure if I agree with how this proposal is implemented. It would likely make more sense as an interface rather than a...

There are unit tests and they executed as part of a build. Worth double check the code

Indeed. Has anything changed since then? Are there still no plans to revisit this design decision? s there any consideration being given to introducing a common interface, or perhaps moving...

Hi @marvin-roesch Can you confirm that this PR fixes your issue. If needed, see how to test a PR ? https://github.com/kubernetes-sigs/external-dns/blob/master/CONTRIBUTING.md#how-to-test-a-pr

@mloiseleur, @szuecs shell we introduce source specific flag for that? One of the options is to hold this change, and I could try to introduce a configuration per-source with config...

Feels like we have incorrect loggin level configured. Should be a debug.

Share your kubernetes manifests with spec section included, and what outcome is expected.

It’s simpler to run multiple external-dns instances than to pack all of this logic into a single one at the moment. There are just too many use cases and combinations...