external-dns icon indicating copy to clipboard operation
external-dns copied to clipboard

feature(ci): generate flags & metrics documentation

Open vflaux opened this issue 7 months ago • 4 comments

What does it do ?

Add jobs check that flags & metrics documentation is up to date.

Motivation

Documentation updates are not validated by CI and changes can be missed in reviews. See #5834

More

  • [x] Yes, this PR title follows Conventional Commits
  • [ ] Yes, I added unit tests
  • [ ] Yes, I updated end user documentation accordingly

vflaux avatar Sep 12 '25 16:09 vflaux

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign raffo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 12 '25 16:09 k8s-ci-robot

Hi @vflaux. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Sep 12 '25 16:09 k8s-ci-robot

There are unit tests and they executed as part of a build. Worth double check the code

ivankatliarchuk avatar Sep 12 '25 17:09 ivankatliarchuk

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 11 '25 17:12 k8s-triage-robot