Ivan Ka
I am open to refactoring the CRDs and annotation, but I have concerns about the current proposal. This change has the potential to significantly impact many of us. Instead of...
And this most likely will block mulitple-targets support or at least not clear how is suppose to work with annotation https://github.com/kubernetes-sigs/external-dns/blob/master/docs/proposal/multi-target.md
I still have concerns if this will work, as it's only cover single case. Example, we currently have dozens of `kind: DNSEndpoint` each with multiple `endpoints:` and provider specific configuration....
Another concern ``` apiVersion: externaldns.k8s.io/v1alpha1 kind: DNSEndpoint metadata: name: examplednsrecord annotations: external-dns.alpha.kubernetes.io/hostname: "subdomain.foo.bar.com" external-dns.alpha.kubernetes.io/target: "other-subdomain.foo.bar.com" external-dns.alpha.kubernetes.io/set-identifier: "some-unique-id" external-dns.alpha.kubernetes.io/aws-failover: "PRIMARY" external-dns.alpha.kubernetes.io/aws-health-check-id: "asdf1234-as12-as12-as12-asdf12345678" external-dns.alpha.kubernetes.io/aws-evaluate-target-health: "true" ``` Why CRD is even required in...
Is any of the kubernetes or kubernetes-sigs project uses similar approach so I can understand better a proposal?
> If I understand correctly, the point here is that the CRD should hold in it's spec definition only the core variables that are the "base" spec, such as DNS...
> This approach and similar pull reqests is a no go for me. I could not approve it, have no issue if other maintainers do approve it. I may have...
I think we should not proceed with proposed approach. More information here https://github.com/kubernetes-sigs/external-dns/pull/4875#issuecomment-2667194251 But I'll try to be structured, with what is wrong to attach annotations on CRD of the...
What for? There is FQDN support https://github.com/kubernetes-sigs/external-dns/blob/master/docs/advanced/fqdn-templating.md. Is way more flexible