Ivan Ka

I forget that if I approve on review, it adds auto-approval.

Hi. Nice on, I'll do an initial review. /label tide/merge-method-squash

/label tide/merge-method-squash

Hi. Gateway CRDs is not something I'm familiar with. Too many legacy projects, so need some time to understand in full Gateway API. Before to review code, would you be...

My recent testing/review supports the discussion found at with https://github.com/kubernetes-sigs/external-dns/pull/5319#discussion_r2059673797. With slightly a difference, not to add new annotations, but to support something very similar to `--annotation-filter` for override default...

It's tough for me to suggest a solution without potentially disrupting someone's workflow, as I haven't personally encountered a use case that requires this yet. I'm currently working on a...

This is how/where the function `getHostByName` defined https://github.com/helm/helm/blob/dde5c2aaf091ff0be0adba627d4dbf53e71f9076/pkg/engine/engine.go#L242 At the moment we have 3 options 1. Redefine whole Helm.Render interface. High efort 2. Mock https://github.com/helm/helm/blob/dde5c2aaf091ff0be0adba627d4dbf53e71f9076/pkg/engine/engine.go#L37. Engine is not an `interface`,...

So in AWS provider we catch all errors and returning soft errors. Example zone handling with soft error no matter what the reason is https://github.com/kubernetes-sigs/external-dns/blob/c5af75e38014680109454fd5f67e1a97d0e5e837/provider/aws/aws.go#L641 or https://github.com/kubernetes-sigs/external-dns/blob/c5af75e38014680109454fd5f67e1a97d0e5e837/provider/aws/aws.go#L373. There are multiple...

Hi @dixneuf19 I found your comment in cloudlare go https://github.com/cloudflare/cloudflare-go/issues/4155 Are you interested to improve stability of the cloudflare provider? If yes, you could try to address proposed solution one-by-one...

https://github.com/kubernetes-sigs/external-dns/issues/5540