Haejoon Lee

Results 95 comments of Haejoon Lee

I agree it might be better to add those APIs to official docs with reasonable reasons. cc. @HyukjinKwon @ueshin what do you think?

@HyukjinKwon okay i'll add them to official docs while i'll work for #1003

Hi, @anilbey ! Thanks for the contribution for PySpark. Seems like you might need to address some stuffs as below: - For running the test properly, could you check the...

> ``` > Warning, treated as error: > /__w/spark/spark/python/docs/source/reference/pyspark.pandas/resampling.rst:2:Explicit markup ends without a blank line; unexpected unindent. > make: *** [Makefile:35: html] Error 2 > ------------------------------------------------ > Jekyll 4.2.1 Please...

> what about also changing `dev/requirements.txt` Maybe we don't need to set an upper bound for pandas in `dev/requirements.txt` because `pip install -r dev/requirements.txt` always install the latest pandas when...

Yeah, I think we should make the test pass since pandas-on-Spark should follow the behavior of latest pandas. Let me take a look. Thanks!

Thanks for the comments! Let me investigate the test failure and make an umbrella ticket if there are many failures. If there is few failures, let me handle them in...

Thanks for the review, @HyukjinKwon and @zhengruifeng ! Just addressed the comments