spark
spark copied to clipboard
add ignore for the recently added and failing mypy error 'type-var' SPARK-39811
A new error introduced to mypy is found in this repository. This PR adds comment to ignore that error.
spark (https://github.com/apache/spark)
- python/pyspark/ml/wrapper.py:267: error: A function returning TypeVar should receive at least one argument containing the same Typevar [type-var]
Reference: https://github.com/python/mypy/pull/13166
Jira Issue: https://issues.apache.org/jira/browse/SPARK-39811
Can one of the admins verify this patch?
Please note that ignoring the type error is not the best solution.
Ideally the return type should be changed to avoid this error in the first place.
Hi, @anilbey ! Thanks for the contribution for PySpark.
Seems like you might need to address some stuffs as below:
-
For running the test properly, could you check the "Workflow run detection failed" in the https://github.com/apache/spark/pull/37210/checks?check_run_id=7404721464 ? You should enable the Github Actions workflow running on your forked repository to run the CI.
-
Could you fix the title in the proper format? It should be of the form
[SPARK-xxxx][COMPONENT] Title, which is described in https://spark.apache.org/contributing.html.- e.g.
[SPARK-39811][PYTHON] add ignore for the recently added and failing mypy error 'type-var'.
- e.g.
-
Let's use the existing PR description format without any modifying. It should be of the form:
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!