spark icon indicating copy to clipboard operation
spark copied to clipboard

[SPARK-40327][PS][DOCS] Add resampling to API references

Open zhengruifeng opened this issue 3 years ago • 2 comments

What changes were proposed in this pull request?

Add resampling to API references

Why are the changes needed?

Docs for resampling is missing

Does this PR introduce any user-facing change?

yes, new docs

How was this patch tested?

existing UT

zhengruifeng avatar Sep 20 '22 10:09 zhengruifeng

Warning, treated as error:
/__w/spark/spark/python/docs/source/reference/pyspark.pandas/resampling.rst:2:Explicit markup ends without a blank line; unexpected unindent.
make: *** [Makefile:35: html] Error 2
                    ------------------------------------------------
      Jekyll 4.2.1   Please append `--trace` to the `build` command 
                     for any additional information or backtrace. 
                    ------------------------------------------------

@itholic @HyukjinKwon @Yikun Do you have any ideas? It keep failing like this, even though I tried several changs

zhengruifeng avatar Sep 21 '22 04:09 zhengruifeng

Warning, treated as error:
/__w/spark/spark/python/docs/source/reference/pyspark.pandas/resampling.rst:2:Explicit markup ends without a blank line; unexpected unindent.
make: *** [Makefile:35: html] Error 2
                    ------------------------------------------------
      Jekyll 4.2.1   Please append `--trace` to the `build` command 
                     for any additional information or backtrace. 
                    ------------------------------------------------

@itholic @HyukjinKwon @Yikun Do you have any ideas? It keep failing like this, even though I tried several changs

Seems like the lines should be aligned as below:

 ..  Licensed to the Apache Software Foundation (ASF) under one
-or more contributor license agreements.  See the NOTICE file
-distributed with this work for additional information
-regarding copyright ownership.  The ASF licenses this file
-to you under the Apache License, Version 2.0 (the
-"License"); you may not use this file except in compliance
-with the License.  You may obtain a copy of the License at
+    or more contributor license agreements.  See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership.  The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License.  You may obtain a copy of the License at

 ..    http://www.apache.org/licenses/LICENSE-2.0

 ..  Unless required by applicable law or agreed to in writing,
-software distributed under the License is distributed on an
-"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-KIND, either express or implied.  See the License for the
-specific language governing permissions and limitations
-under the License.
+    software distributed under the License is distributed on an
+    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+    KIND, either express or implied.  See the License for the
+    specific language governing permissions and limitations
+    under the License.

itholic avatar Sep 21 '22 05:09 itholic

Merged into master, thank you guys!

zhengruifeng avatar Sep 22 '22 05:09 zhengruifeng