Michael Stillwell
Michael Stillwell
Cloudflare changed their cacheDomain from `cdn.cloudflare.com` to `amp.cloudflare.com` which meant that the fixture didn't match `caches.json`. (Maybe should be using a `caches.json` fixture for tests…)
ampbench unexpectedly reports structured data failures: https://ampbench.appspot.com/validate?url=https%3A%2F%2Finsidious-eyelash.glitch.me The SDTT does not report any errors: https://search.google.com/structured-data/testing-tool#url=https%3A%2F%2Finsidious-eyelash.glitch.me (Originally reported as https://github.com/ampproject/amphtml/issues/22103.)
The ampbench server seems unable to fetch some URLs:  (See https://www.washingtonpost.com/photography/2018/06/07/amp-stories/inside-beautiful-overgrown-abandoned-chinese-town/, https://ampbench.appspot.com/validate?url=https%3A%2F%2Fwww.washingtonpost.com%2Fphotography%2F2018%2F06%2F07%2Famp-stories%2Finside-beautiful-overgrown-abandoned-chinese-town%2F.) This seems to be because the server is actively rejecting connections from...
See https://github.com/ampproject/amphtml/issues/21418#issuecomment-472984483
We might not be checking for the correct image sizes, check that it matches [the documentation](https://www.ampproject.org/docs/reference/components/amp-story) and also reality.
Before we do any more work on fixing bugs and adding features, I think some project housekeeping is warranted. I suggest: - [x] Update all packages to latest versions. -...
A URL like https://cnn.com/ampstories/us/who-is-sandra-day-oconnor is actually redirected to https://www.cnn.com/ampstories/us/who-is-sandra-day-oconnor. The CORS checks need to be use the redirected URL, not the original URL. Actual: ```sh # returns 401 curl -i...
https://www.ampproject.org/docs/reference/components/amp-video#noaudio
Chrome's [Lighthouse](https://developers.google.com/web/tools/lighthouse/) performs accessibility audits. It would be useful to incorporate these into ampbench runs. Options to investigate: - https://glitch.com/edit/#!/ispwa (self-hosted) - https://lighthouse-ci.appspot.com/try (via API) - ? (As suggested by...
The AMP Story tests currently check to see that the actual and specified sizes of SVGs are similar. This seems to be routinely violated in practice, and it's probably okay...