Michael Stillwell
Michael Stillwell
**Incomplete, do not merge!** @garanj perhaps you could have a light look over this and see if there are any larger/architectural things that could be improved? There's some obvious things...
> Never rename the ServiceWorker script file Sometimes this can be helpful, in particular in cases where you can't change the service worker itself, but it imports scripts (perhaps from...
If resources are being served with considered cache-control headers, `toolbox.networkFirst` is probably the correct strategy to use. This probably should be called out in the documentation. (Similarly, the docs should...
Documenting partly because I like this behaviour and don't want it to change ;-)
When loaded via the live blog does not appear to ever receive updates: ![screen shot 2016-11-05 at 11 51 04](https://cloud.githubusercontent.com/assets/51244/20029805/58533252-a34e-11e6-80d9-0c227f01f122.png)
The `application/signed-exchange` version of ABE is not valid: ![screenshot 2019-02-26 at 15 32 05](https://user-images.githubusercontent.com/51244/53424830-da9f3a00-39db-11e9-8baf-11fc23f54ed9.png) This is probably because amppackager needs to be updated. (Note: screenshot generated by sending `amp-cache-transform: google`...
- [ ] Add support for AMP Story ad screen sizes (e.g. full-bleed mobile, full-screen desktop) — #1567 - [ ] Create template based on https://support.google.com/admanager/answer/9038178, make it possible to...
Actual: ```sh $ curl -sSi https://ampbyexample.com/json/bookend.json | grep -i '^content-type' content-type: text/plain; charset=utf-8 ``` Expected: ```sh $ curl -sSi https://ampbyexample.com/json/bookend.json | grep -i '^content-type' content-type: application/json; charset=utf-8 ``` The current...
It's possible to change the size of the preview window at https://ampbyexample.com/playground/ (by using the dropdown), which changes the URL to something like: https://ampbyexample.com/playground/#mode=Custom&width=600&height=450 However, the state is not actually...
This is quite bizarre. For large files, `oneBehindFetch()` does not return any response: ```js const fetch = require("@ampproject/toolbox-core").oneBehindFetch; fetch("https://amp.dev/manifest.json") .then((res) => res.text()) .then((text) => console.log(`length of manifest.json = ${text.length}`)); fetch("https://amp.dev/")...