Itamar Turner-Trauring

Potential performance improvement, maybe

3

At https://github.com/BurntSushi/aho-corasick/blob/master/src/classes.rs#L46, the `alphabet_len` is calculated each time the function is called. This function is called in (what appears to me to be) a hot inner function, `next_state()`. It seems...

cargo chef prepare always looks at dev dependencies, but those may not be relevant if building in release mode

3

`cargo chef prepare` is failing for me because it's looking for a dev dependency it can't find during a Docker build. Since I am going to build in release mode,...

In async/await part of documentation, link to Django APIs

1

https://docs.djangoproject.com/en/3.2/topics/async/

Apparently in old Python iscoroutinefunction could do better (and maybe the `asyncio` variant is better than the `inspect` variant? check.) See https://github.com/django/asgiref/blob/main/asgiref/sync.py#L32

Use os.register_at_fork to make crochet work better with e.g. multiprocessing

2

https://docs.python.org/3/library/os.html#os.register_at_fork sounds like it might make Crochet not break when `multiprocessing` default mode is used.

Python 3.7 has a queue that is re-entrancy safe, so in 3.7 we can omit the additional event loop used for the self-pipe trick. AFAICT there are no backports, though,...

Document that running crochet tests in subclass of trial's TestCase may be a problem

2

This can lead to dirty reactor warnings. Suggest SynchronousTestCase instead.

Crochet's shutdown strategy is problematic

1

1. A thread named MainThread doesn't always exist (see #69, some comments #78). 2. Shutting down when the main thread exits may be the wrong thing to do; perhaps the...

Sometimes Crochet is the wrong thing (e.g. Hendrix might be useful, perhaps in conjunction), or its superiority can be pointed out by comparing to existing alternatives.